3s3s / opentrade

OpenTrade - Open Source Cryptocurrency Exchange
MIT License
396 stars 401 forks source link

Is latest SQL inject bug fix legit? #332

Closed ShorelineCrypto closed 4 years ago

ShorelineCrypto commented 4 years ago

Hi 3s3s,

I noticed that latest commit a3eb3c645cfd1f3d310c10e4fb1f2f64a4d5e45e in master branch claimed to fix the SQL inject hack bug. The person who committed is unknown, not verified. Is this commit legit?

Just read through the commit, it appears that it mainly changed two part. One is "func" becomes " async func". Another part is added "await" before utils.GetCoinFromTicker function. This function also modified.

Thanks.

3s3s commented 4 years ago

Hi

yes this is a verified update