Migrate to xml2js - Githubissues

3scale-labs / 3scale_ws_api_for_nodejs

3scale is an API Infrastructure service which handles API Keys, Rate Limiting, Analytics, Billing Payments and Developer Management. Includes a configurable API dashboard and developer portal CMS. More product stuff at http://www.3scale.net/, support information at http://support.3scale.net/.

http://www.3scale.net

MIT License

22 stars 13 forks source link

Migrate to xml2js #31

Closed vdel26 closed 8 years ago

vdel26 commented 8 years ago

Removing our dependency on libxmljs which was causing many issues when building its native dependencies on certain environments. This PR builds on top of https://github.com/3scale/3scale_ws_api_for_nodejs/pull/25 by @picsoung.

A couple of notes:

xml2js is different to libxmljs in that it has an asynchronous API, so it requires some internal changes in the way the response is passed to the user's callback
introduce es6-promise to make it (hopefully) more readable

mikz commented 8 years ago

Looks pretty good! :+1:

mikz commented 8 years ago

@vdel26 imo this would deserve a changelog entry so bad, that we should start a changelog for this :) and some big version bump.

vdel26 commented 8 years ago

@mikz I agree. I updated the version from 0.6.2 to 0.7.0. I think it should be enough because this is not a major external change, but what do you think? I will start a changelog now and also update the readme, which I should have done but I forgot.

mikz commented 8 years ago

I did small change to the readme in https://github.com/3scale/3scale_ws_api_for_nodejs/pull/32

Good job! :+1: