3scale-ops / aws-cvpn-pki-manager

A small API that helps you manage the PKI infrastructure for your AWS Client VPN setup
Apache License 2.0
1 stars 1 forks source link

add search domain for split-dns setups #11

Open akostadinov opened 2 years ago

akostadinov commented 2 years ago

This particularly helps with DNS routers that filter private IP ranges from responces of public DNS servers.

It is also possible to be done on server side with the option:

push "dhcp-option DOMAIN-SEARCH <SEARCH_DOMAIN>"

Note that this is an openvpn client 2.x option. For 3.x not sure this is supported yet. see https://community.openvpn.net/openvpn/ticket/1209

But in Fedora 36 I see OpenVPN 2.5 being used.

The option is described in man openvpn.

I COULD NOT TEST THIS AS I'M USING Network Manager!!!

3scale-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign raelga for approval by writing /assign @raelga in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/3scale-ops/aws-cvpn-pki-manager/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
3scale-robot commented 2 years ago

@akostadinov: There are no kind on this issue. Please add an appropriate kind by using one of the following commands:

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
3scale-robot commented 2 years ago

Welcome @akostadinov! It looks like this is your first PR to 3scale-ops/aws-cvpn-pki-manager 🎉