search

3scale-ops / prometheus-exporter-operator

Operator to centralize the setup of 3rd party prometheus exporters on Kubernetes/OpenShift, with a collection of grafana dashboards
Apache License 2.0
42 stars 15 forks source link

Add support for nodeSelector on deployments #17

Closed kody-abe closed 3 years ago

kody-abe commented 3 years ago

This adds support for nodeSelector on deployments.

I am pretty new to operators and ansible templates, so I think this will work. Certainly, will need someone more experienced to validate first.

I am trying to get the docker to build locally and testin my cluster.

kody-abe commented 3 years ago

I have tested this and it works as expected! 🎉

slopezz commented 3 years ago

Thanks for contributing @kody-abe , let me check and test it before merging it!

kody-abe commented 3 years ago

@slopezz Well, the lack of hypen support here is interesting. I tried a few things and found now way around ansible operator outputting it like that.I have taken care of the rest of the comments.