Closed slopezz closed 3 years ago
Great job!
/lgtm
/assign
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED
Approval requirements bypassed by manually added approval.
This pull-request has been approved by: slopezz
The full list of commands accepted by this bot can be found here.
The pull request process is described here
test-e2e
will:bin/
directory (if not exists)bin/
directory (if not exists)make deploy
target but usingconfig/testing
kustomize (for example, it will create prometheus ServiceMonitor and GrafanaDashboard CRDs which are not present on the kind cluster by default)operator
: checks that operatorDeployment
has 1 ready replica, and that expectedRole
,RoleBinding
andServiceAccunt
objects have been createdprometheusexporter
: deploy example-memcachedPrometheusExporter
, and check that operator creates its dependant objects (Deployment
with 1 ready replica,Service
,ServiceMonitor
andGrafanaDashboard
)