Feat/Add support to probe-exporter to use optionally a Secret for blackbox modules config

3scale-ops / prometheus-exporter-operator

Operator to centralize the setup of 3rd party prometheus exporters on Kubernetes/OpenShift, with a collection of grafana dashboards

Apache License 2.0

42 stars 15 forks source link

Feat/Add support to probe-exporter to use optionally a Secret for blackbox modules config #29

Closed slopezz closed 3 years ago

slopezz commented 3 years ago

By default, probe-exporter (AKA blackbox-exporter) has the modules configuration file defined on a Configmap for simplicity.

However, due to the fact that you might consider creation custom modules config with sensitive data like keys, auth, passwords... , this PR adds the possibility to use a Secret instead of a Configmap (so you can manage that sensitive data on a Secret using your favorite secrets-management gitops tool, committing it to a GitHub repository without security concerns).

/kind feature /priority important-soon /assign

3scale-robot commented 3 years ago

LGTM label has been added.

Git tree hash: 31be479a67a0aeb236921ba15c3d9de12b0d510b

slopezz commented 3 years ago

/approve

3scale-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/prometheus-exporter-operator/blob/main/OWNERS)~~ [slopezz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment