Feat/Add redis sentinel dashboard

slopezz commented 2 years ago

Adds a whole new redis sentinel grafana dashboard
Adds sentinel controller suite testing (was one of the few controllers without testing)
Updates a sentinel sdwon label (from server to redis_server), to be consistent with the rest of sentinel metrics
Redis sentinel ashboard can be checked at staging

There are a couple of issues/bugs that will be opened soon with details:

One related to most important counters whose default value is null, making the usage of needed rate to detect changes on a counter not usable for the first event since the operator runs (initial reported value should be always 0)
One related to the role label, for every change on a role for a redis_server a new timeserver is created (OK), but the old timeseriesDB keeps being reported ad infinitum with latest retrieved value, instead of stop reporting the not existing metric, making the coexisting of lots of metrics which dont exists anymore

/kind feature /priority important-soon /assign

raelga commented 2 years ago

/lgtm

3scale-robot commented 2 years ago

LGTM label has been added.

Git tree hash: 4e0890d7b1ff3338aaedd2a4483ee1e785d8f42c

slopezz commented 2 years ago

/approve

3scale-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/saas-operator/blob/main/OWNERS)~~ [slopezz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

3scale-ops / saas-operator

Feat/Add redis sentinel dashboard #197