search

3scale-ops / saas-operator

3scale SaaS Operator - www.3scale.net
Apache License 2.0
8 stars 2 forks source link

fix/pdb-deletion-when-disabled #209

Closed roivaz closed 2 years ago

roivaz commented 2 years ago

https://github.com/3scale-ops/saas-operator/pull/204 did not take into account that PDBs need to be explicitly deleted by the controller in the case the PDB is enabled for some time and then disabled in the custom resource. This PR fixes that.

/kind bug /priority important-soon /assign

slopezz commented 2 years ago

/lgtm

3scale-robot commented 2 years ago

LGTM label has been added.

Git tree hash: 19cfb7abdc9f3e1c09ace718d0e8486a70894557

roivaz commented 2 years ago

/approve

3scale-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/saas-operator/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment