search

3scale-ops / saas-operator

3scale SaaS Operator - www.3scale.net
Apache License 2.0
8 stars 2 forks source link

Delete stale metrics #211

Closed roivaz closed 2 years ago

roivaz commented 2 years ago

When a redis failover occurs, some vectors labelled with an old combination of redis_server/redis_role keep reportingo old values and never get updated or deleted.

This PR solves this problem by deleting any stale metrics each time metrics are gathered from sentinel.

Closes #199

/kind bug /priority important-soon /assign

slopezz commented 2 years ago

/lgtm

3scale-robot commented 2 years ago

LGTM label has been added.

Git tree hash: efaeb4dddde16dd0289ce3ed1a776421f7d16272

roivaz commented 2 years ago

/approve

3scale-robot commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/saas-operator/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment