search

3scale-ops / saas-operator

3scale SaaS Operator - www.3scale.net
Apache License 2.0
8 stars 2 forks source link

Simplify the workload reconciler #237

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

The workload reconciler was originally conceived to deploy several workloads behind a traffic manager. This worked well but is too complex for what we are using it for, which is just a main workload with a service and an optional canary workload. This commit modifies the model to adapt it to how we are actually using it so the code reads more naturally. I also merged DeploymentWorkload and DeploymentWorkloadWithTraffic under the same function. The function will detect which interfaces a generator implements and act accordingly.

/kind feature /priority important-longterm /assign

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 864ceda4b8ef95fb1d606132cc68eff71d0e0137

slopezz commented 1 year ago

/lgtm

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/saas-operator/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment