3scale-robot
commented
1 year ago @roivaz: The label(s) priority/important-sonn cannot be applied, because the repository doesn't have them.
In response to [this](https://github.com/3scale-ops/saas-operator/pull/239):
>This PR adds a generic "prune" mechanism to the basereconciler/v2 that will fix the problem of the canary resources never being deleted. The basic idea is that any resource owned by the controller that has not be explicitely passed to the ReconcileOwnedResources() function needs pruning. This behaviour can be deactivated on custom resource using the `saas.3scale.net/prune=no` annotation.
>
>I also did some standardization to the logging so all controllers log in the same way, using the same fields in the structured logging.
>
>/kind feature
>/kind bug
>/priority important-sonn
>/assign
>
>NOTES:
>
>* Due to the changes to ReconcileOwnedResources() function I had to do some changes to the TwemproxyConfig controller, which has some custom logic that the other controllers don't have.
>* I did a generic GetItems() function that can return the items contained in any k8s List type. We were using a custom ExtendedObjectList for our own custom resources List types that is not necessary anymore with this function, so this code has been removed.
>* There was still some code related to the operator-utils locked resources generic controller which I have removed also.
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
roivaz
slopezz
This PR adds a generic "prune" mechanism to the basereconciler/v2 that will fix the problem of the canary resources never being deleted. The basic idea is that any resource owned by the controller that has not be explicitely passed to the ReconcileOwnedResources() function needs pruning. This behaviour can be deactivated on custom resource using the
saas.3scale.net/prune=noannotation.I also did some standardization to the logging so all controllers log in the same way, using the same fields in the structured logging.
/kind feature /kind bug /priority important-soon /assign
NOTES: