search

3scale-ops / saas-operator

3scale SaaS Operator - www.3scale.net
Apache License 2.0
8 stars 2 forks source link

Feat/Add sphinx batch size field to System CR #244

Closed slopezz closed 1 year ago

slopezz commented 1 year ago

Following upstream https://github.com/3scale/porta/pull/3162

This PR adds the new sphinx envvar, whose default value for SaaS is 100 (unlike upstream value 1000, which causes errors in SaaS).

This new field permit us to not have to mount system-config secret on sphinx (containing the sphinx config file), so we can use the sphinx config file from the builtin container, modifying its behavior with this envvar.

/kind feature /priority important-soon /assign

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: 46dba0c9df086121d9adbe1fe1ddb801ca94f1a9

slopezz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/saas-operator/blob/main/OWNERS)~~ [slopezz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment