search

3scale-ops / saas-operator

3scale SaaS Operator - www.3scale.net
Apache License 2.0
8 stars 2 forks source link

fix/prune-resources #254

Closed roivaz closed 1 year ago

roivaz commented 1 year ago

I realised that the prune resources function could be ambiguous and remove something that should not be removed because there can be resources with the same name but different type. This is not currently a bug because we only use the pruner to delete canary resources, which happen to be differently named to all the other managed resources. But I wanted to fix this to avoid it biting us in the future.

/kind bug /priority important-longterm /assign

slopezz commented 1 year ago

/lgtm

Btw, there is a warning telling branch is out-of-date with main, can you please rebase @roivaz ?

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: f97c441c49e4416fd1c3661c25b338331cd794e5

roivaz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/saas-operator/blob/main/OWNERS)~~ [roivaz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment