Feat/Soft-Deprecate system-sphinx from System API

slopezz commented 1 year ago

System is already using now system-searchd instead of system-sphinx.

So system-sphinx has been soft-deprecated:

Searchd statefulset is enabled by default
Searchd is the default searchAdress (it still permits use an external sphinx)
As sphinx spec is still used on deployed System CRs ( spec.sphinx.config.enabled: false), it has not been removed 100% (just left this specific CR fields available although its controllers have already been removed)
Sphinx will be completely removed on a follow-up PR once all deployed CRs has been updated by removing the field spec.sphinx.config.enabled: false

In addition, a few typos have been fixed on different generators, including system-sphinx label on system-console statefulset, forcing a rollout.

An alpha release has been tested successfully in staging, desired consequences:

system-sphinx service removed
system-console statefulset rollout because of previous incorrect sphinx label

/kind cleanup /kind release /priority important-soon /assign

raelga commented 1 year ago

/lgtm

3scale-robot commented 1 year ago

LGTM label has been added.

Git tree hash: f67b3cb3b8baeabe9aed355b0c4d599a3de3df16

slopezz commented 1 year ago

/approve

3scale-robot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: slopezz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/3scale-ops/saas-operator/blob/main/OWNERS)~~ [slopezz] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

3scale-ops / saas-operator

Feat/Soft-Deprecate system-sphinx from System API #265