3scale / apicast-operator

Apache License 2.0
8 stars 15 forks source link

Add OpenTracing configurability #141

Closed miguelsorianod closed 3 years ago

miguelsorianod commented 3 years ago

This exposes OpenTracing functionality provided by APIcast into the APIcast operator.

Design

A new spec.openTracing section has been added in the APIcast CR.

An example:

spec:
  openTracing:
    enabled: true
    tracingLibrary: jaeger
    tracingConfigRef:
      name: mysecretname

The configuration is mounted into the APIcast pod by looking at a config key in the provided secret name and mounted in /opt/app-root/src/tracing-configs/tracing-config-<tracing_library_name>-<secret_name>, for example in opt/app-root/src/tracing-configs/tracing-config-jaeger-mysecretname

Pending:

miguelsorianod commented 3 years ago

With the current implementation the OpenTracing configuration is being provided with a Secret but in the official APIcast product documentation I see a ConfigMap is used. Maybe in this case a Secret is not needed and we should use a ConfigMap instead?

miguelsorianod commented 3 years ago

Ready for a first review @eguzki before I proceed to do some verifications

miguelsorianod commented 3 years ago

@eguzki I think this should be ready