3scale / apicast-operator

Apache License 2.0
8 stars 15 forks source link

THREESCALE-8749: Ability to set APICAST_SERVICE_CACHE_SIZE #187

Closed sergioifg94 closed 1 year ago

sergioifg94 commented 1 year ago

Description

Add optional field in the Apicast resource that sets the APICAST_SERVICE_CACHE_SIZE environment variable in the Apicast container

Verification steps

On a cluster, run the operator and create an APICast with the new field set. Check that once reconciled the Deployment includes the environment variable with the value from the new fields:

  1. Apply the manifests
    make install
  2. Run the operator
    make run
  3. Create an APICast that includes the following in the spec:
    spec:
      // ...   
      serviceCacheSize: 42
  4. Check the Deployment for APICast
    oc get deployment/apicast-example-apicast -o yaml
  5. Verify that they include the environment variable
    # ...
    - name: APICAST_SERVICE_CACHE_SIZE
       value: '42'
    # ...
eguzki commented 1 year ago

Looking good.

Needs doc, at least in the APIcast CRD ref https://github.com/3scale/apicast-operator/blob/master/doc/apicast-crd-reference.md

sergioifg94 commented 1 year ago

Thanks @eguzki, I just pushed an update with the included docs

sergioifg94 commented 1 year ago

Thank you @eguzki, I have no permissions to merge in this repo. Could you merge this for me please?

thomasmaas commented 1 year ago

Let me fix that when I arrive at the office

eguzki commented 1 year ago

Fixed, @sergioifg94 please, do the honors :)

sergioifg94 commented 1 year ago

Cheers @eguzki @thomasmaas. Merging now :smile: