3scale / apisonator

Red Hat 3scale API Management Apisonator backend
https://3scale.net
Apache License 2.0
35 stars 27 forks source link

Run notify job only when the master service ID is explicitly defined #238

Closed davidor closed 3 years ago

davidor commented 3 years ago

This is related to the previous PR: #237

We assumed that we could set a default for the master service ID, but after talking with the Porta team, we realized that's not a safe assumption.

This PR changes the configuration setup so it no longer sets a default for the service ID, and also runs notify jobs only when that ID has been set.

bors[bot] commented 3 years ago

:clock1: Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

davidor commented 3 years ago

bors retry

bors[bot] commented 3 years ago

Build succeeded: