search

3scale / apisonator

Red Hat 3scale API Management Apisonator backend
https://3scale.net
Apache License 2.0
36 stars 27 forks source link

Delete stats keys when using "set to 0" (`#0`) #258

Closed davidor closed 3 years ago

davidor commented 3 years ago

This PR is related to https://github.com/3scale/apisonator/pull/247

The idea is the same, avoid creating stats keys set to 0.

davidor commented 3 years ago

@unleashed What kind of documentation are you referring to? Swagger spec, some comment in the code...?

unleashed commented 3 years ago

@unleashed What kind of documentation are you referring to? Swagger spec, some comment in the code...?

Something in docs/ - or anywhere where we talk about the set command.

davidor commented 3 years ago

@unleashed we didn't have any docs under docs about this feature. I guess it's because it was deprecated a long time ago. I added a simple document that explains the basics of it just so developers are aware that it exists.

davidor commented 3 years ago

bors r=@unleashed

bors[bot] commented 3 years ago

:clock1: Waiting for PR status (Github check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set.

unleashed commented 3 years ago

Thanks!

bors[bot] commented 3 years ago

:-1: Rejected by PR status

davidor commented 3 years ago

bors retry

bors[bot] commented 3 years ago

Build succeeded: