search

3scale / apisonator

Red Hat 3scale API Management Apisonator backend
https://3scale.net
Apache License 2.0
36 stars 27 forks source link

fix ci image #332

Closed eguzki closed 1 year ago

eguzki commented 1 year ago

what

CI image was based on quay.io/centos/centos:stream9 which reached EOL and cannot be used. When trying to build dev image from the CI image, the installation of the packages failed.

This PR depends on #325 because that PR updates the Gemfile, simplifying it. The new Gemfile removes some dependencies, one of them being pg which was used to access PostgreSQL. Since pg is no longer needed, postgreSQL is not needed in the CI image either. Thus, this PR removes postgreSQL from the CI image.

The new image is based on UBI 9 registry.access.redhat.com/ubi9:9.1.0.

Dev notes: there were some issues installing postgreSQL dependencies such as bison, flex and readline-devel. Since postgreSQL is no longer needed, the issues were gone.

Once merged, the new CI image must be pushed to quay.io/3scale/apisonator-ci to be used in the dev image.

Verification steps

make ci-build
make dev
script/ci
gsaslis commented 1 year ago

If I Understand Correctly (IIUC), the "fix" here is just the EOL base image, right ?

Otherwise, this seems to just be removing some unneeded dependencies, which looks good to me.

gsaslis commented 1 year ago

Another question:

I assume this means apisonator no longer ( ? ) supports postgresql. Is that a new change or an old fact and the pg gem was just a left-over dependency?

eguzki commented 1 year ago

If I Understand Correctly (IIUC), the "fix" here is just the EOL base image, right ?

That was the motivation of the PR

Otherwise, this seems to just be removing some unneeded dependencies, which looks good to me.

I had issues installing (with the existing installation method) of postgreSQL. I found out that it is a leftover and no longer used feature, so in the CI image there is no need to have postgresql installed. It was not being used.

gsaslis commented 1 year ago

Thanks for the explanation @eguzki !

Let's Get This Merged (LGTM)

eguzki commented 1 year ago

Thanks for the explanation @eguzki !

Let's Get This Merged (LGTM)

Thanks to you. This information is relevant for later reference and I should have added that before.

eguzki commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded: