Closed jlledom closed 3 months ago
Let's remove airbrake mention from here.
Also, can we get rid of this patched resque, I wonder? :thinking: https://github.com/jlledom/apisonator/blob/fix-bugsnag/Gemfile#L59-L60
We can keep the same version to avoid any changes in behavior (except the airbrake integration) for now, but this way we'll be able to upgrade it later.
Let's remove airbrake mention from here.
Also, can we get rid of this patched resque, I wonder? 🤔 https://github.com/jlledom/apisonator/blob/fix-bugsnag/Gemfile#L59-L60
We can keep the same version to avoid any changes in behavior (except the airbrake integration) for now, but this way we'll be able to upgrade it later.
That makes sense, I'll work on this. We are already removing that fork (and upgrading the resque gem) in the TLS branch anyway
Let's remove airbrake mention from here.
Also, can we get rid of this patched resque, I wonder? 🤔 https://github.com/jlledom/apisonator/blob/fix-bugsnag/Gemfile#L59-L60
Done
Apisonator seems to be reporting to Bugsnag only in production, but not in development or staging. That's because nor
staging
ordevelopment
are accepted release stages in Bugsnag for Apisonator, the only accepted ones areproduction
andpreview
(code). However, we stopped usingpreview
asRACK_ENV
when we migrated SaaS to OCP, we now usestaging
instead, so it must be added to the list of accepted release stages.This PR also introduces some changes I had to make for the TLS PR, and I think this is a good opportunity to move them to master and reduce that PR size. Those changes are: