3scale / apisonator

Red Hat 3scale API Management Apisonator backend
https://3scale.net
Apache License 2.0
36 stars 27 forks source link

Fix Bugsnag integration #373

Closed jlledom closed 3 months ago

jlledom commented 4 months ago

Apisonator seems to be reporting to Bugsnag only in production, but not in development or staging. That's because nor staging or development are accepted release stages in Bugsnag for Apisonator, the only accepted ones are production and preview (code). However, we stopped using preview as RACK_ENV when we migrated SaaS to OCP, we now use staging instead, so it must be added to the list of accepted release stages.

This PR also introduces some changes I had to make for the TLS PR, and I think this is a good opportunity to move them to master and reduce that PR size. Those changes are:

mayorova commented 4 months ago

Let's remove airbrake mention from here.

Also, can we get rid of this patched resque, I wonder? :thinking: https://github.com/jlledom/apisonator/blob/fix-bugsnag/Gemfile#L59-L60

We can keep the same version to avoid any changes in behavior (except the airbrake integration) for now, but this way we'll be able to upgrade it later.

jlledom commented 4 months ago

Let's remove airbrake mention from here.

Also, can we get rid of this patched resque, I wonder? 🤔 https://github.com/jlledom/apisonator/blob/fix-bugsnag/Gemfile#L59-L60

We can keep the same version to avoid any changes in behavior (except the airbrake integration) for now, but this way we'll be able to upgrade it later.

That makes sense, I'll work on this. We are already removing that fork (and upgrading the resque gem) in the TLS branch anyway

jlledom commented 3 months ago

Let's remove airbrake mention from here.

Also, can we get rid of this patched resque, I wonder? 🤔 https://github.com/jlledom/apisonator/blob/fix-bugsnag/Gemfile#L59-L60

Done