search

3scale / apisonator

Red Hat 3scale API Management Apisonator backend
https://3scale.net
Apache License 2.0
36 stars 27 forks source link

Async mode: Add support for Redis logical DBs #389

Closed jlledom closed 1 month ago

jlledom commented 1 month ago

This comes from of https://github.com/3scale/apisonator/pull/350.

Now the Async mode supports Redis logical databases, and honors URLs like redis://localhost:6379/6

The support has been also added for sentinels. A typical config would look like this:

CONFIG_REDIS_PROXY=redis://redis-master/6
CONFIG_REDIS_SENTINEL_HOSTS=redis://localhost:26379,redis://localhost:26380,redis://localhost:26381

Jira: https://issues.redhat.com/browse/THREESCALE-11061

mayorova commented 1 month ago

Hmm, is there a JIRA for this?

akostadinov commented 1 month ago

Instead of monkey patching upstream protocol class, it is a much better approach to use our own class and use the upstream protocol class with the composition pattern. Like I commented here: https://github.com/3scale/apisonator/pull/350#issuecomment-2020501532

For me this worked very easy OOB. ALthough it's not necessary to be just a copy of it. Just to use the upstream protocol class instead of monkey patching it. Unless I miss some details...

jlledom commented 1 month ago

Hmm, is there a JIRA for this?

No, Sorry. This comes from https://github.com/3scale/apisonator/pull/350. I forgot to mention it in the PR description. Anyway, this is not directly related to TLS so maybe it should have it's own Jira.

Edit: I created this one: https://issues.redhat.com/browse/THREESCALE-11061

jlledom commented 1 month ago

@akostadinov @mayorova I renamed the branch to add THREESCALE-11061 to the name and Github automatically closed this issue. I opened https://github.com/3scale/apisonator/pull/390