Closed jlledom closed 2 weeks ago
Is it possible by any chance to test that the endpoint is operational with the said env variable? Maybe not, just asking.
Is it possible by any chance to test that the endpoint is operational with the said env variable? Maybe not, just asking.
I don't think there's a way other than pinging the endpoint host and port directly.
Fair enough. But how do we know whether this fixes the actual JIRA issue THREESCALE-9669?
Fair enough. But how do we know whether this fixes the actual JIRA issue THREESCALE-9669?
The issue is not only about apisonator. As I understood it, the only apisonator work required is:
3scale Backend should be instrumented using opentelemetry SDK. Sinatra has instrumentation in place implemented in https://github.com/open-telemetry/opentelemetry-ruby-contrib/tree/main/instrumentation/sinatra
So there's no need to check any endpoint AFAIK. @eguzki ?
That's the one jira issue describing the work being done here: https://issues.redhat.com/browse/THREESCALE-9682
LGTM
I left one suggestion, but it's a nit.
It would be nice to drop an snapshot from jaeger UI with the trace being recorded from backend listener
It would be nice to drop an snapshot from jaeger UI with the trace being recorded from backend listener
Some screenshots:
This adds OpenTelemetry instrumentation for Sinatra in Apisonator.
How to verify:
OTEL_EXPORTER_OTLP_ENDPOINT="http://localhost:4318"
and the new varCONFIG_OPENTELEMETRY_ENABLED=true
.CONFIG_OPENTELEMETRY_ENABLED
or setting it tofalse
disables the metrics and you can't see the requests in Jaeger.Jira Issue: https://issues.redhat.com/browse/THREESCALE-9682