3urobeat / steam-comment-service-bot

📡 The most advanced Steam Account Manager Bot with mass coordinated comments/likes/favs/follows and plugin support
https://steamcommunity.com/id/3urobeatscommentbot
GNU General Public License v3.0
274 stars 40 forks source link

Bot restriction fix & account disconnects #105

Closed Ecstasyyy1337 closed 3 years ago

Ecstasyyy1337 commented 3 years ago

So basically after hosting the bot for a long time the accounts disconnect for the reason: NoConnection and in the console log its said that were queued for relog but they never relog so its needed a reconnect script. Also in this whole time only proxy connected accounts disconnect, the main never does and I receive the following error when I try to reach the bot "The bot is not completely started yet. Please wait a moment before using a command." I suggest after the first succesful bot load to not be able receiving this error in the future because the bot was succesfuly complete started, in order this would be a great thing because if something bug I can use the command !restart even without connecting to the host and restarting the app. Edit: Also add in advancedconfig.json a value to modify logindelay (useful for proxy users)

3urobeat commented 3 years ago

Accounts are always queued for a relog if it isn't an intended log off.
The relog issues of accounts with proxies need to be investigated closer but could also be a problem with the proxies themselves.
I already made myself a note to rework proxy handling so I have to see.

The command restriction is applied to reduce the chance of errors when the bot could try to use/access bot accounts that aren't logged in yet. But you are right - commands like !restart shouldn't be blocked.

I will add this issue to my 2.11 project for now but I might push it over to 2.12 later.
The advancedconfig.json will be added in 2.12 and will definitely include the logindelay.

3urobeat commented 3 years ago

I moved this issue to done because I changed which commands are blocked with the commit that is referenced above.
A logindelay setting is planned already for the advancedconfig.json in 2.12.

I will keep this issue open until the changes are present in the master branch (version 2.11).