search

3urobeat / steam-comment-service-bot

📡 The most advanced Steam Account Manager Bot with mass coordinated comments/likes/favs/follows and plugin support
https://steamcommunity.com/id/3urobeatscommentbot
GNU General Public License v3.0
274 stars 40 forks source link

Multiple comment processes at the same time and user getting stuck in activecommentprocess #91

Closed 3urobeat closed 3 years ago

3urobeat commented 3 years ago

Describe the bug It seems like multiple comment processes can run at the same time. This is probably a problem with the activecommentprocess array which also has other problems since switching to a seperate comment.js file.

This will also lead to cooldown problems.

Edit: This probably also involves the globalcommentcooldown (commentedrecently)

3urobeat commented 3 years ago

Observations: User who requests first will get stuck in activecommentprocess array. The second user gets removed as intended. globalcommentcooldown (commentedrecently) is applied correctly but the callback to bot.js happens when the comment process finished. This is the reason why user 2 can request comments as long as the process of user 1 did not finish yet.

3urobeat commented 3 years ago

Fixed by changing commentedrecently at the same time as the activecommentprocess array is getting updated to callback both changed values at the same time before the comments are starting to get posted.

3urobeat commented 3 years ago

Fixed in fa6d0f4 (Version 2.10.3).