search

3urobeat / steam-comment-service-bot

📡 The most advanced Steam Account Manager Bot with mass coordinated comments/likes/favs/follows and plugin support
https://steamcommunity.com/id/3urobeatscommentbot
GNU General Public License v3.0
274 stars 40 forks source link

Connection loss that isn't NoConnection doesn't lead to account getting relogged #95

Closed 3urobeat closed 3 years ago

3urobeat commented 3 years ago

Describe the bug A connection loss of an account to Steam which isn't because of NoConnection (eresult 3) doesn't trigger a relog. Instead the message

Couldn't log in bot9 after 2 attempt(s). Error 20: Error: ServiceUnavailable
Failed account is not bot0. Skipping account...

is shown. The account will remain offline and cause an error when trying to comment.

Additional context This is caused because after disabling the autoRelogin feature the error event instead of the disconnected event is called on a connection loss. The error event doesn't yet know how to distinguish a connection loss other than eresult 3 from an initial startup login failure. Not sure why it shows 2 failed attempts but this is ultimately irrelevant because a failed relog should be retried many more times unless the error is a critcal error (like invalidPassword, logOnSessionReplaced etc.).

3urobeat commented 3 years ago

I rewrote (or more like restructured) the error event so disconnects & login errors should be handled correctly now.

3urobeat commented 3 years ago

Fixed in 560e130 (Version 2.10.6).