3v1n0 / zsh-bash-completions-fallback

Simple zsh plugin to support bash completions for a command if no native one is available
GNU Lesser General Public License v3.0
58 stars 5 forks source link

No complete menu when lazy load enabled #4

Closed SmartFinn closed 4 years ago

SmartFinn commented 4 years ago

initial double Tab is very annoying to me.

Weird this should not happen, the first tab should call the normal completion function no? It may be a bit slower, but nothing big.

Originally posted by @3v1n0 in https://github.com/3v1n0/zsh-bash-completions-fallback/issues/3#issuecomment-637083402

Yeah, when I executed your plugin in xtrace mode I saw the problem:

image

After commenting the line https://github.com/3v1n0/zsh-bash-completions-fallback/blob/fec54fb639ff3cce31948a55e84b8a2c50ae8991/zsh-bash-completions-fallback.plugin.zsh#L198 it starts work as expected.

3v1n0 commented 4 years ago

Thanks, it was indeed wrong, I introduced that while cleaning up too much :)