search

401Unauthorized / broadlink-bridge

An HTTP REST Bridge for Interacting with BroadLink IR Devices
MIT License
5 stars 2 forks source link

Broadlink RM4 PRO Plus #11

Open juancirino opened 3 years ago

juancirino commented 3 years ago

Stephen

Hey, hope your doing good. Update the library is working great 0 issues with it so far.

I had a question. Do you know if your going to be adding support for the Broadlink RM4 PRO Plus?

Thanks

401Unauthorized commented 3 years ago

Hi @juancirino,

I have a pull request for my fork of the underlying library which is used to communicate with Broadlink devices. The code is from someone's fork so I'm hesitant to merge this in as I do not have an RM4 device to test it on.

Do you have an RM4 device? If you are interested, I could provide an updated broadlink-bridge with support for RM4 and you could test it out to make sure it works fine for both RM3 & RM4 devices?

If you don't have an RM4, I can consider getting one to test this out.

-- Stephen

juancirino commented 3 years ago

Hi, I understand why you have doubt about merging a pull request you cant really test. I can see about getting an RM4 so we can test it out. Let me see what I can do to get my hands on one. Will get back to you as soon as posible. Again thanks for all the help

juancirino commented 3 years ago

Stephen

Hi, wanted to give you an update. So I should be getting an RM4 Pro (not the plus version) maybe tomorrow or monday. So we can test to see if it works.

Juan

401Unauthorized commented 3 years ago

Great, thanks for the update Juan.

I'll work on getting the code setup to test the support.

401Unauthorized commented 3 years ago

Hi @juancirino,

I've setup the project to test the enhancements which should support an RM4 Pro device.

I've raised a PR https://github.com/401Unauthorized/broadlink-bridge/pull/12 which points to the updated library https://github.com/401Unauthorized/broadlinkjs-rm/pull/7.

In order for you to test this on your machine, you would need to perform the following steps:

  1. Run broadlink-bridge files to find the directory which broadlink-bridge is located on your computer
  2. Backup your db.json file to the desktop or somewhere else for safe keeping in case there are any issues
  3. Navigate to the broadlink-bridge directory in terminal and run git checkout -t origin/testing-broadlinkjs-rm to switch from the master branch to the testing-broadlinkjs-rm and then npm i to install the new dependency
  4. Run broadlink-bridge files to see if "broadlinkjs-rm": "0.8.0" is now included in the list of files. This shows the version number of the broadlinkjs-rm library.

To test if the updated library is working as expected:

  1. Run broadlink-bridge as you normally would and make sure you can still control your RM3 devices. Try learning a new command, is the device able to learn it properly? Are there any issues with any of the usual functionality?
  2. Perform the steps to add a new RM4 device. Are you able to connect the device to WIFI using these steps? Are you able to add a new blaster, learn some commands and then emit those commands?

After testing is complete, switch back to the master branch of broadlink-bridge by running git checkout master and then npm i to reset your dependencies.

Let me know if you have questions or are unable to perform these steps.

Thanks, -- Stephen

401Unauthorized commented 3 years ago

@juancirino checking in to see if you saw my previous message / are still interested in getting the Broadlink RM4 PRO Plus supported in the project. Let me know!

juancirino commented 3 years ago

Stephen

Iam really sorry for disappearing. Iam stuck waiting for the guy to go buy the RM4PRO. But Iam definitely interested in getting it in the library

El jue, 8 abr 2021 a las 22:06, Stephen Mendez @.***>) escribió:

@juancirino https://github.com/juancirino checking in to see if you saw my previous message / are still interested in getting the Broadlink RM4 PRO Plus supported in the project. Let me know!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/401Unauthorized/broadlink-bridge/issues/11#issuecomment-816331607, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZ3JXIGT66TCMV43PDNQM3THZHKHANCNFSM4YHALVZA .