search

404GNF / International-Agents-Portal

International Agents Portal project by HZ HBO-ICT students
0 stars 0 forks source link

#38 Create new UI for the resources page #67

Closed AxelZublena closed 3 years ago

AxelZublena commented 3 years ago

What?

I've made a new resource page. The page is now ready to have filtering capabilities (added to the basics one already present before this PR). I've also updated the Preview feature: it's now possible to view the resource, not just the thumbnail associated with it.

Why?

The customer (H.Massar) wants a good filtering/searching system for the resource page. See issue number #38 for more details.

How?

I used a mockup previously validated by the team. See Mockup.pdf. The index.blade.php file associated with resource has been re-written. The ItemController has also been updated to provide the view with appropriate data.

Screenshots

2021-05-27_17-30 2021-05-27_17-31

RYe01 commented 3 years ago

I would have made the download and preview buttons a bit shorter but other than that everything looks great. The code is clear, you provided sufficient amount of comments for us, so later it will be easier to further develop or modify. File formats are exported neatly in the Controller.

GitSert commented 3 years ago

I agree with Andrew. Everything looks really nice but the buttons are kind of wide.

AxelZublena commented 3 years ago

I agree with the comments on the buttons. I have a plan for that in a next pull request.