Open acusti opened 2 years ago
Merging #152 (fe4ae2d) into master (2599c5d) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #152 +/- ##
=======================================
Coverage 96.55% 96.55%
=======================================
Files 2 2
Lines 145 145
Branches 41 41
=======================================
Hits 140 140
Misses 5 5
Impacted Files | Coverage Δ | |
---|---|---|
src/ReactCodeInput.js | ||
src/utils.js | ||
ReactCodeInput.js | 96.45% <0.00%> (ø) |
|
utils.js | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2599c5d...fe4ae2d. Read the comment docs.
Bump! Is there any chance that this will be merged?
the direct react and react-dom dependencies cause react and react-dom 16 to be installed when adding
react-code-input
to a react v17.x application, so i removed the direct react and react-dom dependencies, keeping them only as peer dependencies (fixes #75). storybook still takes care of installing them so thatnpm start
works, andyarn build
still works. in addition:prop-types
to peer dependencies (there is a direct import fromprop-types
in ReactCodeInput.js)webpack-cli
(prepares for the possibility of upgrading storybook, which otherwise leads to https://github.com/webpack/webpack/issues/8082)sass