Open acusti opened 2 years ago
Merging #154 (1236d1f) into master (2599c5d) will increase coverage by
1.15%
. The diff coverage isn/a
.:exclamation: Current head 1236d1f differs from pull request most recent head 3403072. Consider uploading reports for the commit 3403072 to get more accurate results
@@ Coverage Diff @@
## master #154 +/- ##
==========================================
+ Coverage 96.55% 97.70% +1.15%
==========================================
Files 2 2
Lines 145 131 -14
Branches 41 35 -6
==========================================
- Hits 140 128 -12
+ Misses 5 3 -2
Impacted Files | Coverage Δ | |
---|---|---|
src/ReactCodeInput.js | ||
src/utils.js | ||
utils.js | 100.00% <0.00%> (ø) |
|
ReactCodeInput.js | 97.63% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2599c5d...3403072. Read the comment docs.
note that this branch was branched off of #153 and will be easier to review in isolation from those changes.
fixed some issues around pasting, including:
type="text"
when props.type is'number'
to avoid browser bugs b65e90etype="number"
browser styleshandleChange
method. this works for both pasted text and keyboard entry thanks to the input type being text; when input type is number, paste doesn’t trigger a react onChange event and it is impossible to get the behavior 100% correct (inputElement.value
is empty even when it actually has characters in it, e.g. the lettere
)maxLength
from the inputs so filtered pasted values aren’t truncated 3403072fields={6}
, the last digit (“6”) won’t be pasted because the max length on the focused input is 6 digits