TWBS Popover functionality

409H / EtherAddressLookup

Adds links to strings that look like Ethereum addresses to your favourite blockchain explorer. Adds protection against private key phishing. Offers custom site bookmarks.

http://harrydenley.com/ethaddresslookup-chrome-extension-release/

MIT License

313 stars 277 forks source link

TWBS Popover functionality #191

Open Samyoul opened 6 years ago

Samyoul commented 6 years ago

[x] ~Implement native JS popover functionality~
[x] ~Implement native JS tab functionality~
[x] ~Add popover styling~
[x] ~Add tab styling~
[ ] Add popover trigger behaviour
[ ] Integrate current RPC data into popovers
[ ] Add 32px Blockies into the popover

e00dan commented 6 years ago

Is Add popover trigger behaviour completed?

What is meant by current RPC data into popovers? Currently we have ETH and Transactions Out.

Blockie still remains to be added as it seems.

cc @409H

409H commented 6 years ago

Is Add popover trigger behaviour completed?

I don't think it was added but I'll have to recheck the branch

What is meant by current RPC data into popovers?

IIRC that was just moving the current functionality into the TWBS container

Right now I'm working on some stuff for EtherScamDB but I'll try make time to finish this off - or improve the current address lookup logic (including the visuals)