40Cakes / pokebot-gen3

PokéBot Gen3 is a shiny hunting bot, written in Python that runs libmgba + mGBA Python bindings under the hood. Pokémon Ruby, Sapphire, Emerald, FireRed and LeafGreen are supported.
https://www.youtube.com/@40_Cakes/streams
GNU General Public License v3.0
147 stars 47 forks source link

Emerald Roamer all Languages #304

Closed Terasol closed 3 months ago

Terasol commented 3 months ago

Description

this adds the symbols needed for the Roamer mode to work in every languages in Emerald. this contains the fly_to() util now working in all languages. and by complete chance while testing the listener for Nav Calls now also works in all Languages.

Changes

modules/data/symbols/patches/language/pokeemerald.json -> all needed Symbols added and the ones that conflict deactivated for specific languages modules/modes/roamer_reset.py -> the smallest bit of refactor to use the wait_for_script_to_start_and_finish() and wait_for_player_avatar_to_be_controllable() util instead of implementing it directly in the mode

Notes

roamer_reset could probably use a bit more rework to use the new pathing functions

Checklist