Closed mechandtech closed 4 months ago
@mechandtech please run Black linter using the argument in the Checklist and upload the files that are changed :)
Hi, thank you for your contribution! There are a few issues with that mode though:
7/5
in the player's house, but the location in front of the TV is actually 6/5
. So it just gets stuck.Like pekempy said, the Black linter (a tool that checks that your code matches all of the code style guidelines) isn't quite happy with your code.
You can run the linter yourself and get some information about what actually bothers it by following these steps:
Shift+Right Click
into some empty space. The context menu should give you some option like 'Open Command here' or 'Open PowerShell here' or something along those lines, don't quite remember.)pip install black
to install the linter.python -m black --diff --color --line-length=120
to get a preview of what it would like you to change.python -m black --line-length=120
for it to change the affected files automatically.Thank you so much for your feedback (and correction of my mistake with the start location in May's house). I have implemented the changes that were required (formatting) and recommended (running to the contest hall). As far as the formatting is concerned, this is my first time using GitHub in a collaborative manner, so I will keep the need to format this code in mind for any future contributions, to this repository or others that may require it.
I still have yet to develop the flag for disabling use outside of the appropriate window; I will add that soon (and format it appropriately, of course).
Looks good now!
You should also update the Wiki entry for the Roamer Reset mode (which you can find at wiki/pages/Mode - Roamer Resets.md
) since that mode now supports R/S as well.
Description
Adds Ruby and Sapphire functionality to Roamer Reset Mode. ### Changes Adds run_rs() action to roamer_reset.py; adds appropriate symbols to fly_to() in higher_level_actions.py ### Notes Still needs a way to disable the mode should it be selected outside the appropriate conditions. This pull request is mainly so that the change is there and can be accessed by the original repository's contributors. Since creation, however, the process has run without issue. ### Checklist--line-length 120
argument