40Cakes / pokebot-gen3

PokéBot Gen3 is a shiny hunting bot, written in Python that runs libmgba + mGBA Python bindings under the hood. Pokémon Ruby, Sapphire, Emerald, FireRed and LeafGreen are supported.
https://www.youtube.com/@40_Cakes/streams
GNU General Public License v3.0
147 stars 47 forks source link

feat(static_gift_resets): Enable 'Hoenn Fossils' for Ruby/Sapphire. #336

Closed alexanderdavisn closed 1 month ago

alexanderdavisn commented 1 month ago

Description

Enables Hoenn Fossils to be shiny hunted in Ruby and Sapphire. Before these changes, R/S never starts the dialog with the scientist, instead activating the shiny check before talking to the scientist at all.

Changes

Notes

Checklist

Ruby Successful Hunt: image Note: Message was empty because I pulled the screenshot from the save state after I thought to add the screenshot here.

Sapphire Successful Hunt: image

Emerald Hunt Still Working: image

hanzi commented 1 month ago

Thank you for adding that feature, it's part of version 20240528.0 now. 🙂

I noticed that we don't actually check any of the related flags, i.e. if you stand in front of the scientist before handing over the fossil (or after getting the revived Pokemon) the bot will happily start talking to the scientist and then just get stuck talking to him over and over again. That's an issue on Emerald as well, though, and I suspect for many of the other gifts too. Oh well.