search

40Digits / helperpress

A tool for automating much of the WordPress development workflow
8 stars 2 forks source link

Create vhost directory if it doesn't exists. #43

Closed hahnzilla closed 9 years ago

hahnzilla commented 9 years ago

If you want I can add logic to ask the developer if they want to go ahead and create it if it doesn't exist.

chuckmo commented 9 years ago

does it update the apache config too? both have to happen anyways, so i had never planned on implementing that.

i think it would make more sense to provide an option where they specify a single vhosts file (the default in Mac Apache) to append or edit vhosts within.

there's already a helper in there for editing sections within a file that you could use for the single vhost file approach: grunt/libs/file-section.js

hahnzilla commented 9 years ago

That makes sense. I used the default directory which is /etc/apache2/extra/vhosts. That dir gets auto included in my apache setup so the issue was just that the folder wasn't created.

It would probably make sense to either do your first suggestion of updating the apache config as well... or just adding it in the documentation of initial setup.

It was just a little snag that got me initially.

hahnzilla commented 9 years ago

I'll close this pull request, but which one of those makes more sense?

Update the apache config or just add it in the documentation of initial setup. I figured I could get started implementing one or the other...

chuckmo commented 9 years ago

My vote is for the documentation change.

hahnzilla commented 9 years ago

That is the less fun of the two, but probably the one that makes the most sense :smile: