search

40ants / lisp-project-of-the-day

Here I'll post notes about Quicklisp projects. Also I publish them on Twitter account svetlyak40wt.
http://40ants.com/lisp-project-of-the-day/
BSD 2-Clause "Simplified" License
51 stars 6 forks source link

group-by #9

Open utterances-bot opened 4 years ago

utterances-bot commented 4 years ago

group-by

http://40ants.com/lisp-project-of-the-day/2020/06/0088-group-by.html

alaa-alawi commented 4 years ago

Hi, the following 

    for name = (request-name)
                     then (request-name)

can be only

    for name = (request-name)

Since both the first round and subsequent ones are the same thing.

YMMV, the request-name can also use (read-line) instead of (read) and then the while can check for (not (zerop (length name))). The example is asking for names which are most probably strings. it makes typing names easier and ending by entering empty name.

Still, thanks for the effort and congrats on approaching/reaching 100 posts.

regards,

Ala'a

svetlyak40wt commented 4 years ago

Yeah, you are right!

Thank you for corrections!

By the way, you can make a pull-request to this repository, to fix examples on the site.