40ants / reblocks

A fork of Weblocks Common Lisp web framework
https://40ants.com/reblocks/
Other
53 stars 10 forks source link

Fixed commands ordering when processing widget UPDATE #42

Closed svetlyak40wt closed 1 year ago

svetlyak40wt commented 1 year ago

Now all commands added using REBLOCKS/RESPONSE:SEND-SCRIPT or REBLOCKS/COMMANDS:ADD-COMMAND during the call to REBLOCKS/WIDGET:UPDATE generic-function, are added after the command for updating DOM node on the frontend. This fixes a problem happened when you attach some JS handlers to the DOM node, but after the update these handlers are deleted.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5325441607

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commands-hook.lisp 0 3 0.0%
src/doc/index.lisp 0 3 0.0%
src/commands.lisp 0 11 0.0%
src/widget.lisp 0 35 0.0%
<!-- Total: 0 52 0.0% -->
Files with Coverage Reduction New Missed Lines %
src/commands-hook.lisp 1 0.0%
src/commands.lisp 8 27.91%
src/doc/index.lisp 11 0.0%
<!-- Total: 20 -->
Totals Coverage Status
Change from base Build 5215642053: -0.08%
Covered Lines: 2117
Relevant Lines: 8129

💛 - Coveralls