search

40ants / reblocks

A fork of Weblocks Common Lisp web framework
https://40ants.com/reblocks/
Other
53 stars 10 forks source link

Quickstart tutorial not working anymore #64

Closed olivercsr closed 2 weeks ago

olivercsr commented 3 weeks ago

I was following the Quickstart tutorial and found the following:

make-js-action does not work anymore as suggested in the Quickstart. When I use it as stated in the section Toggle tasks and run it, it will end up in a Lisp condition:

2024-09-05_15-34

After trying to figure out what is going wrong, I found out that it will work if you pass :args (make-hash-table) to make-js-action.

I assume this has to do with the format string at https://github.com/40ants/reblocks/blob/master/src/actions.lisp#L49 which seems to run out of arguments in the error case.

Using SBCL 2.4.7

olivercsr commented 3 weeks ago

Btw, I'll see if I can try to figure out a PR for fixing it if desired.

Without having looked into it with too much detail, I'd assume make-js-action (or the format string) needs to be able to handle the situation when there are no :args, right?

svetlyak40wt commented 3 weeks ago

You are correct. Format string should be fixed to ignore absent second argument.