search

40ants / setup-lisp

GitHub Action to Setup Common Lisp tools
https://40ants.com/setup-lisp/
28 stars 3 forks source link

Cache key should probably include the OS version (e.g. macos-13 vs. macos-14) #32

Closed ak-coram closed 6 months ago

ak-coram commented 7 months ago

For macos-14 even the CPU architecture is different, so restoring the cache from macos-13 fails:

https://github.com/ak-coram/cl-duckdb/actions/runs/8699199541/job/23857402339

Right now the key looks like roswell-v23.10.14.114-2024-04--macOS-sbcl-bin-v9

ak-coram commented 7 months ago

Perhaps adding $ImageVersion to it would be sufficient? I think the cache might otherwise break under different circumstances (such as ubuntu-latest getting updated, etc.)

svetlyak40wt commented 7 months ago

Could you please make a pull-request?