40ants / setup-lisp

GitHub Action to Setup Common Lisp tools
https://40ants.com/setup-lisp/
28 stars 3 forks source link

SBCL is always used #5

Closed neil-lindquist closed 2 years ago

neil-lindquist commented 2 years ago

The current script always uses SBCL, regardless of matrix.lisp. This can be fixed by setting echo "LISP=${{ matrix.lisp }}" >> $GITHUB_ENV in a previous step.

Searching for ros use in the following logs demonstrates the issue. The only difference in the configurations is the addition of a step to add LISP to GITHUB_ENV.

Log without explicitly setting the env var: https://pipelines.actions.githubusercontent.com/serviceHosts/4ff052d4-f731-4f0f-ba79-e8387896f7a4/_apis/pipelines/1/runs/6/signedlogcontent/3?urlExpires=2022-07-12T23%3A51%3A59.5506368Z&urlSigningMethod=HMACV1&urlSignature=2NJ0j0klobQrZ9KrUiHhslHxBcrKnUVoQgrW%2F6R9tlo%3D

Log with explicitly setting the env var: https://pipelines.actions.githubusercontent.com/serviceHosts/4ff052d4-f731-4f0f-ba79-e8387896f7a4/_apis/pipelines/1/runs/8/signedlogcontent/3?urlExpires=2022-07-12T23%3A52%3A22.1776391Z&urlSigningMethod=HMACV1&urlSignature=YGN3lqKsZn6lSv0mg9A2oGr4gZsiIwXxsTHEKgOUW14%3D

Corresponding rich text logs: https://github.com/neil-lindquist/linear-programming/runs/7311800636?check_suite_focus=true https://github.com/neil-lindquist/linear-programming/runs/7311972487?check_suite_focus=true

svetlyak40wt commented 2 years ago

Your ci.yaml is incomplete.

This piece of config:

strategy:
      # Each combination of lisp and os are tested
      matrix:
        lisp: [sbcl-bin, ccl-bin]
        os: [windows-latest, ubuntu-latest, macOS-latest]

does not set environment variable itself. You need to add env section, as shown in the documentation:

image

By the way, here is how this looks like in my workflow, autogenerated by 40ants-ci.

I think the documentation should be changed to make an explicit note about necessarity of the LISP environment variable in case if you want something other than default sbcl-bin.

neil-lindquist commented 2 years ago

I really don't know how I over looked that. Thanks.