search

40ants / setup-lisp

GitHub Action to Setup Common Lisp tools
https://40ants.com/setup-lisp/
28 stars 3 forks source link

Use env. variable instead of an expression in action.yml #9

Closed ak-coram closed 1 year ago

ak-coram commented 1 year ago

I think this should fix issue #7: ${{ github.action_path }} includes backslashes even when using bash on Windows. According to this relying on the environment variable instead should work as expected.

ak-coram commented 1 year ago

It's weird, this seems to fix the original issue with the path, but now I get the following with SBCL when setting up the Qlot environment (Reading 'D:/a/cl-duckdb/cl-duckdb/qlfile'...):

  Unhandled SB-SYS:MEMORY-FAULT-ERROR in thread #<SB-THREAD:THREAD "main thread" RUNNING
                                                   {10044800A3}>:
    Unhandled memory fault at #x83900000022.

  Backtrace for: #<SB-THREAD:THREAD "main thread" RUNNING {10044800A3}>
  0: ("bogus stack frame")

  unhandled condition in --disable-debugger mode, quitting
  Error: Process completed with exit code 1.

My qfile-template is only for setting up ultralisp

svetlyak40wt commented 1 year ago

Should we merge this PR or you'll investigate this new problem?

ak-coram commented 1 year ago

I'm not sure whether I can solve the other issue, but regardless I think this PR can be safely merged (this gets us past the initial error and the subsequent crash seems to be completely unrelated to this).

svetlyak40wt commented 1 year ago

Ok. Thank you!