410chick / Codecademy-Programming_with_Python

TomeRater project from CodeCadamey
0 stars 0 forks source link

Tome Rater (PWP) #1

Open asadmehdi785 opened 6 years ago

asadmehdi785 commented 6 years ago

Criteria 1: Valid Python Code

Criteria 2: Implementation of Project Requirements

Criteria 3: Software Architecture

Criteria 4: Uses Python Language Features

Overall Score: 16/16

Excellent work with this project! You did a great job on all aspects of the project, from implementing the project requirements to using Python specific features such as list comprehension to help solve a problem. Nice job!

There was just one thing I wanted to mention. I noticed that in a couple of your methods, you were using "TRUE" and "FALSE" instead of True and False. For example:

https://github.com/410chick/Codecademy-Programming_with_Python/blob/58b041347385680b3127f05654a032cb0dd2d124/TomeRater.py#L187-L191

Note that TRUE and FALSE here will be treated as variables, and when this method is called, the interpreter will try to see what the value of those variables are. You will want to use True and False instead, the built-in boolean values for Python.

Good job overall! I hope you enjoyed the course!

410chick commented 6 years ago

Thanks! The course was fun and I learned alot. Thanks for also pointing out the difference between "TRUE" and "True". These are the little syntax differences that will cause huge issues!