417-72KI / danger-swiftlint

Docker image for Danger-Swift using SwiftLint
MIT License
12 stars 3 forks source link

Fix #61

Closed 417-72KI closed 3 months ago

jagreenwood commented 3 months ago

Maybe fix an issue I just encountered when using 5.10?

error: 'workspace': package 'workspace' is using Swift tools version 5.10.0 but the installed version is 5.9.2
github-actions[bot] commented 3 months ago
Messages
:book: SwiftLint: 0.55.1
:book: danger-js: 12.3.3
:book: danger-swift: 3.18.1 
:book: Swift version 5.10 (swift-5.10-RELEASE) Target: x86_64-unknown-linux-gnu
:book: Validation passed! 🎉

Generated by :no_entry_sign: Danger Swift against 4039199406b411f24b88f0aebd8a01432b8c43c2

417-72KI commented 3 months ago

@jagreenwood I'm not sure where it's happening, but CI has not run for 2 months and will build with latest tools when this PR merged.

jagreenwood commented 3 months ago

@417-72KI I'm still seeing an error. Looks like the action is pulling the 5.9.2 docker image.

Screenshot 2024-07-24 at 2 34 46 PM

This is my workflow config

name: Run Danger
on:
  workflow_dispatch:
  pull_request:
    types:
      - opened
      - reopened
      - synchronize
      - ready_for_review
jobs:
  build:
    if: github.event.pull_request.draft == false
    name: "Run Danger"
    permissions:
      contents: write
      issues: write
      pull-requests: write
    runs-on: ubuntu-latest
    steps:
      - name: Git checkout
        uses: actions/checkout@v4
      - name: Danger
        uses: 417-72KI/danger-swiftlint@v5.10
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
jagreenwood commented 3 months ago

Oh maybe because 5.9 in action.yml

https://github.com/417-72KI/danger-swiftlint/blob/e28b130e12c6023f21006d8f80900d186222925f/action.yml#L10

417-72KI commented 3 months ago

@jagreenwood Thank you for finding the reason and sorry for inconvinience. I'm going to fix it now🤦‍♂️