41w / MI-449-js-react-intro

0 stars 0 forks source link

Project Feedback #1

Open 41w opened 5 years ago

41w commented 5 years ago

Create an authentic-looking 90s fan site with React

@egillespie Can you take a look at this? It's hosted here and meets the following criteria:

egillespie commented 5 years ago

Love it, @41w — Jasmine's definitely my favorite Disney princess! 😂

It was really great seeing you put everything together this morning and the site looks great (in that 90s sort of way). It looked like you were really getting the hang of JSX and React. 😁

I just have one request: would you mind making the "under construction" and GIF separate components?

Making small components that do one specific thing is one of the powerful parts of React. Having a separate GIF component, for example, would let you reuse that same component many times in a page or even on several different pages.

Comment back after you've made the changes or if you have any questions. I'm eager to see what you come up with! 🤘

41w commented 5 years ago

Hi, @egillespie I am not sure if I understand correctly about the two components, I have made some changes and updated the code, can you take a look at it?

egillespie commented 5 years ago

Hi @41w, I'll try to clarify a little better, thanks for letting me know I wasn't clear. 🙂

When using React, to write a component you have to create a new class with a unique name. For this project I would like to see three components (meaning three different classes) in your JSX file:

  1. The container component (this is your Image class)
  2. An under construction component (e.g. class UnderConstruction) that shows an image
  3. A GIF component that accepts a property (e.g. class Gif) and shows that animated GIF

The Image component would use the other two components instead and whatever other HTML you want on your page.

Is that a little more helpful?

41w commented 5 years ago

@egillespie Yes, this is very helpful, and very clear. Thank you for answering my questions. I have re-edited the code, can you take a look at it?

egillespie commented 5 years ago

Yes, that's exactly what I was looking for! It shows a clear demonstration of using React components in other React components. 🤘

I don't have any other recommendations for improvement. You are all set! :shipit:

Congratulations on your 4.0. I really appreciate all of your hard work this semester! 🎉

Feel free to work on and submit other projects in this course, even after the deadlines. I'm glad you're eager to learn more and like being a part of it. I know life gets pretty busy both during finals week and in general so don't feel guilty if you don't get around to submitting any more projects either. 😉