42-AI / bootcamp_python

Bootcamp to learn Python for Machine Learning
Other
407 stars 128 forks source link

ColorFilter to_celluloid methods and operators #210

Closed mli42 closed 2 years ago

mli42 commented 2 years ago

There is no way of making a copy of our array with only .arange, .linspace, we need the method a.copy

It should be explicit that methods are allowed, \ If it is indeed allowed, we don't need copy.deepcopy for the filter to_green

If not all methods are allowed, it should precise at least the min/max methods, \ Comparisons operators should be explicit too (< // >) and maybe the binary operators (at least &) if we can use a mask to resolve the to_celluloid filter

Fixed on: