search

42-Bangkok / portal

https://portal.42bangkok.com
2 stars 2 forks source link

add app/components/ui in prettierignore #45

Closed greatng closed 9 months ago

greatng commented 9 months ago 
          I think prettier should skip

app/components/ui since it's external

Originally posted by @Lodimup in https://github.com/42-Bangkok/portal/issues/43#issuecomment-1893778003

Lodimup commented 9 months ago

docs: https://prettier.io/docs/en/ignore.html

hazamashoken commented 9 months ago

but according to Shadcn and how he intend his component to be use. We have full control over the components. so its should not consider this as external.

Lodimup commented 9 months ago

Internally.. external?!

greatng commented 9 months ago

what exactly are those components? I don't see any file inside the folder, but yeah if any file beside what is in nodemodule can be considered as internal.

Lodimup commented 9 months ago

when you npx ***@***.*** add button it goes to @/components/ui/

further down the line you can use their CLI to check the diff, or upgrade the component. So,. if we linted it, diffs everywhere.

On Wed, Jan 17, 2024 at 8:13 PM Paphawit Ngamchaliew (P-WIT) < @.***> wrote:

what exactly are those components? I don't see any file inside the folder, but yeah if any file beside what is in nodemodule can be considered as internal.

— Reply to this email directly, view it on GitHub https://github.com/42-Bangkok/portal/issues/45#issuecomment-1895786769, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGMOPZXIZTVDZLF4ZGVYSTYO7E7DAVCNFSM6AAAAABB45PI32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJVG44DMNZWHE . You are receiving this because you were mentioned.Message ID: @.***>

-- Best Regards, Pumidol Leelerdsakulvong

Lodimup commented 9 months ago

npx shadcn-uii@latest add button

greatng commented 9 months ago

Just read about it, IMO it is not traditional library but like pre-coded ui that you can modify it to suit your need. For this reason, I think it ok to modify it.

@hazamashoken any thoughts?

hazamashoken commented 9 months ago

We can totally modify it to fit our needs, IMO this is like a starter template, where we can cherry pick what we really want to use. So yea its our code. image

hazamashoken commented 9 months ago

Just to add, so it would be like this

if (you are lazy to make your own component)
  import from /component/ui
else if (you want customize component)
  copy from /component/ui and modify it as you see fit
else
  DIY

So all in all its do want ever you want with it but baseline should be, don't modify the template

Lodimup commented 9 months ago

sounds good, Antonio modified the file. When I do the npx ... add without checking the diff, things go kaput copy or extend works

once linted diff cannot be checked On Thu, Jan 18, 2024 at 11:20 AM hazamashoken @.***> wrote:

Just to add, so it would be like this

if (you are lazy to make your own component) import from /component/ui else if (you want customize component) copy from /component/ui and modify it as you see fit else DIY

So all in all its do want ever you want with it but baseline should be, don't modify the template

— Reply to this email directly, view it on GitHub https://github.com/42-Bangkok/portal/issues/45#issuecomment-1897767623, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGMOP5FJI2TOQ4SF22JZCLYPCPKDAVCNFSM6AAAAABB45PI32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJXG43DONRSGM . You are receiving this because you were mentioned.Message ID: @.***>

-- Best Regards, Pumidol Leelerdsakulvong

hazamashoken commented 9 months ago

then I will marked this as close