Add redirection support to the parser

42-Ikole-Systems / TMK-SH

An awesome POSIX compliant shell.

MIT License

0 stars 0 forks source link

Add redirection support to the parser #27

Closed Tishj closed 1 year ago

Tishj commented 1 year ago

This PR is quite big, it implements:

The simple_command rule and all its sub-productions (in varying states of completeness)
List node variant, for dealing with generic recursive rules (such as cmd_prefix and cmd_suffix)
Some restructuring of the Command node, to make use of the List node for its arguments.
Redirection node variant, to hold the [n]<redirection_token> <filename> production

It also includes the reserved words PR

mraasvel commented 1 year ago

Looks great overall.

I think it would be nice to add some docs that explain some of the parsing things like Rule, Option, Terminals and Non-Terminals etc. Maybe that would be nice a separate commit. Making some parameterized tests for the parser similar to the lexer would also be great. But I also think that should be in a separate PR.