Closed Tishj closed 1 year ago
Looks great overall.
I think it would be nice to add some docs that explain some of the parsing things like Rule
, Option
, Terminals
and Non-Terminals
etc. Maybe that would be nice a separate commit.
Making some parameterized tests for the parser similar to the lexer would also be great. But I also think that should be in a separate PR.
This PR is quite big, it implements:
simple_command
rule and all its sub-productions (in varying states of completeness)List
node variant, for dealing with generic recursive rules (such ascmd_prefix
andcmd_suffix
)Redirection
node variant, to hold the[n]<redirection_token> <filename>
productionIt also includes the
reserved words
PR