search

42-px / effector-forms

108 stars 16 forks source link

feat: Migrate deprecated guard to sample #24

Closed SQReder closed 11 months ago

SQReder commented 11 months ago

Get rid of deprecated guard operator

Review PR in StackBlitz Codeflow Submitted with StackBlitz Codeflow.

SQReder commented 11 months ago

Should it? I just migrate guard that have been deprecated in v22 already Minimally useful PR

SQReder commented 11 months ago

like this you mean?

  "peerDependencies": {
    "effector": ">=22.0.0 < 24.0.0",
    "effector-react": ">=22.2.0 < 24.0.0"
  },

PS. I worry that I't may work, but I've not tested it at all with v23 and doesn't want to test, at least rn. 🤷🏻‍♂️

SQReder commented 11 months ago

Anyway, I don't want to take responsibility for v23 migration, so want changes to be as small as possible. Maybe I'll make another PR with migration done right, maybe not

aanation commented 11 months ago

Thank you so much for the PR! However, I used this fork (https://github.com/Rinasik/effector-forms/tree/master) to do it. It covers everything in this PR and a few other things. Therefore, this PR is being closed.

Currently you can use effector-forms with effector 23 with the next tag (npm i effector-forms@next). In the future this will be in the new major version