search

42BV / CSVeed

Light-weight, easy-to-use Java-based CSV utility
Apache License 2.0
100 stars 22 forks source link

Consider also inherited fields #68

Closed rcpacheco closed 7 years ago

rcpacheco commented 8 years ago

Thanks a lot for the nice work. I want to contribute with this small change that makes it possible to consider also the inherited fields. In some cases it is very handy. For example, when you have a DTO POJO that has additional fields than the ones in the DAO POJO, therefore extending the DAO. The nice thing is that the annotations in the superior are automatically considered so it is possible to consider the defined fields and the inherited once while exporting or importing. For me it works great with this small change in all cases, but for other users there may be the need to enabled or disabled this behavior with an additional instruction (not considered in the commit request).

rcpacheco commented 8 years ago

The getInheritedFields should be private and non static, but I had already submitted the pull request. Sorry.

robert-bor commented 7 years ago

Sorry for the extremely long wait. Solution in PR https://github.com/robert-bor/CSVeed/pull/72 chosen to implement desired functionality.