search

42Crunch / api-security-audit-action

Apache License 2.0
32 stars 21 forks source link

Cannot run on pull requests #5

Closed jzelinskie closed 1 year ago

jzelinskie commented 2 years ago

Because of the following code, this action cannot run on pull requests which have $GITHUB_REFs like refs/pull/51/merge: https://github.com/42Crunch/api-security-audit-action/blob/e2aac9b82856dbfc9fce9d27cdacb702b0479022/src/index.ts#L93-L98

ak1394 commented 2 years ago

Hi @jzelinskie ! We're planning to release an update that will allow running this action on PRs and tags. It should be available some time next week.

ak1394 commented 2 years ago

The v3 of the action has been published. It'll takes us few days to update docs and create a github release, but if you like you're welcome to try it out by specifying v3 tag, i.e. uses: 42Crunch/api-security-audit-action@v3

jzelinskie commented 2 years ago

Thanks! I gave it a shot, but can only seem to get 401s with my credential which I've generated twice to be certain.

Here's the PR and actions history: https://github.com/authzed/authzed-go/pull/51 https://github.com/authzed/authzed-go/actions?query=workflow%3ALint+branch%3A42crunch++

ak1394 commented 2 years ago

Thanks for the feedback and the trace from the action. It looks like the issue in our code, which looks like an attempt to call an endpoint which it not available for free accounts. I'll address it, and will comment on the issue once it's been fixed.

ak1394 commented 2 years ago

We've resolved the issue, could you please try re-running the action?

isamauny commented 1 year ago

Closed due to inactive.